allow hide fields and types - #6
Open
marchenko1985 wants to merge 2 commits into
Open
Conversation
Author
|
Accidentally did push packages upgrade, everything still working (tests and example server) While upgrading added missed If you want I can try to revert it and make separate PR just for versions upgrade, seems like it might solve many issues like #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #1 and my founding we gonna need to be able to hide fields exactly inside this transform not before (wont be able to delegate) not after (gateway wont work)
What have I done in this PR:
hiddento bothFederationFieldConfigandFederationObjectConfignullas possible return type tovisitor- according to spec if we return null node will be removedTest and readme also included
Hope to see it somewhere in near future in your library it will help us move further and connect everything into one beautiful graph without this hacky ways to remove unwanted fields
BR
Alex